Re: [Qemu-devel] [PATCH 05/11] net: milkymist_minimac2: convert SysBus init method to a realize method

[Cédric Le Goater]

On 9/28/18 4:49 PM, Peter Maydell wrote:
> On 28 September 2018 at 14:49, Cédric Le Goater <address@hidden> wrote:
>> Cc: Michael Walle <address@hidden>
>> Signed-off-by: Cédric Le Goater <address@hidden>
>> ---
>>  hw/net/milkymist-minimac2.c | 9 +++------
>>  1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/hw/net/milkymist-minimac2.c b/hw/net/milkymist-minimac2.c
>> index 3eaa19dfde92..5e7304a26a50 100644
>> --- a/hw/net/milkymist-minimac2.c
>> +++ b/hw/net/milkymist-minimac2.c
>> @@ -452,9 +452,9 @@ static NetClientInfo net_milkymist_minimac2_info = {
>>      .receive = minimac2_rx,
>>  };
>>
>> -static int milkymist_minimac2_init(SysBusDevice *sbd)
>> +static void milkymist_minimac2_realize(DeviceState *dev, Error **errp)
>>  {
>> -    DeviceState *dev = DEVICE(sbd);
>> +   SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
> 
> Looks like wrong indent, maybe ?

ah my bad. I did a copy paste for this one.

I Will fix in next round.

Thanks,

C. 

 
> 
> Otherwise
> Reviewed-by: Peter Maydell <address@hidden>
> 
> thanks
> -- PMM
>