Re: [Qemu-devel] [PATCH v6 3/7] target/mips: Support R5900 instructions MOVN, MOVZ and PREF from MIPS IV

[Philippe Mathieu-Daudé]

On 9/15/18 10:43 AM, Fredrik Noring wrote:
> The R5900 is taken to be MIPS III with certain modifications. From
> MIPS IV it implements the instructions MOVN, MOVZ and PREF.

Again, you can keep R-b tag for simple rewording.

> 
> Signed-off-by: Fredrik Noring <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  target/mips/translate.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/target/mips/translate.c b/target/mips/translate.c
> index 7e18ec0d03..0c445c11c5 100644
> --- a/target/mips/translate.c
> +++ b/target/mips/translate.c
> @@ -22422,7 +22422,7 @@ static void decode_opc_special_legacy(CPUMIPSState 
> *env, DisasContext *ctx)
>      case OPC_MOVN:         /* Conditional move */
>      case OPC_MOVZ:
>          check_insn(ctx, ISA_MIPS4 | ISA_MIPS32 |
> -                   INSN_LOONGSON2E | INSN_LOONGSON2F);
> +                   INSN_LOONGSON2E | INSN_LOONGSON2F | INSN_R5900);
>          gen_cond_move(ctx, op1, rd, rs, rt);
>          break;
>      case OPC_MFHI:          /* Move from HI/LO */
> @@ -25006,7 +25006,8 @@ static void decode_opc(CPUMIPSState *env, 
> DisasContext *ctx)
>          break;
>      case OPC_PREF:
>          check_insn_opc_removed(ctx, ISA_MIPS32R6);
> -        check_insn(ctx, ISA_MIPS4 | ISA_MIPS32);
> +        check_insn(ctx, ISA_MIPS4 | ISA_MIPS32 |
> +                   INSN_R5900);
>          /* Treat as NOP. */
>          break;
>  
>