[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 4/4] tests/guest-debug: fix scoping of failco
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v1 4/4] tests/guest-debug: fix scoping of failcount |
Date: |
Tue, 2 Oct 2018 10:59:23 +0100 |
On 26 September 2018 at 12:20, Alex Bennée <address@hidden> wrote:
> You should declare you are using a global version of a variable before
> you attempt to modify it in a function.
>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> tests/guest-debug/test-gdbstub.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/guest-debug/test-gdbstub.py
> b/tests/guest-debug/test-gdbstub.py
> index 474d2c5c65..7bfc95b187 100644
> --- a/tests/guest-debug/test-gdbstub.py
> +++ b/tests/guest-debug/test-gdbstub.py
> @@ -16,6 +16,7 @@ def report(cond, msg):
> print ("PASS: %s" % (msg))
> else:
> print ("FAIL: %s" % (msg))
> + global failcount
> failcount += 1
Reviewed-by: Peter Maydell <address@hidden>
Incidentally, if we ever get above 127 tests in this file,
the "exit(failcount)" at the bottom of the script will
not DTRT :-)
thanks
-- PMM
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v1 4/4] tests/guest-debug: fix scoping of failcount,
Peter Maydell <=