[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/15] hw/pci-host/bonito: Use DeviceState::real
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 06/15] hw/pci-host/bonito: Use DeviceState::realize rather than SysBusDevice::init |
Date: |
Tue, 2 Oct 2018 23:24:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/2/18 12:09 AM, Philippe Mathieu-Daudé wrote:
> Move from the legacy SysBusDevice::init method to using DeviceState::realize.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/pci-host/bonito.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c
> index 9868e2eccc..03d1ec33e3 100644
> --- a/hw/pci-host/bonito.c
> +++ b/hw/pci-host/bonito.c
> @@ -595,7 +595,7 @@ static const VMStateDescription vmstate_bonito = {
> }
> };
>
> -static int bonito_pcihost_initfn(SysBusDevice *dev)
> +static void bonito_pcihost_realize(PCIDevice *dev, Error **errp)
This patch is incorrect, see:
https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00378.html
> {
> PCIHostState *phb = PCI_HOST_BRIDGE(dev);
>
> @@ -603,8 +603,6 @@ static int bonito_pcihost_initfn(SysBusDevice *dev)
> pci_bonito_set_irq, pci_bonito_map_irq,
> dev, get_system_memory(),
> get_system_io(),
> 0x28, 32, TYPE_PCI_BUS);
> -
> - return 0;
> }
>
> static void bonito_realize(PCIDevice *dev, Error **errp)
> @@ -684,7 +682,6 @@ PCIBus *bonito_init(qemu_irq *pic)
> pcihost->pic = pic;
> qdev_init_nofail(dev);
>
> - /* set the pcihost pointer before bonito_initfn is called */
> d = pci_create(phb->bus, PCI_DEVFN(0, 0), TYPE_PCI_BONITO);
> s = PCI_BONITO(d);
> s->pcihost = pcihost;
> @@ -726,9 +723,9 @@ static const TypeInfo bonito_info = {
>
> static void bonito_pcihost_class_init(ObjectClass *klass, void *data)
> {
> - SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
> + PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
>
> - k->init = bonito_pcihost_initfn;
> + k->realize = bonito_pcihost_realize;
> }
>
> static const TypeInfo bonito_pcihost_info = {
>
- [Qemu-devel] [PATCH 00/15] another SysBusDevice::init to Device::realize cleanup, Philippe Mathieu-Daudé, 2018/10/01
- [Qemu-devel] [RFC PATCH 14/15] hw/hppa/dino: Remove unuseful code, Philippe Mathieu-Daudé, 2018/10/01
- [Qemu-devel] [PATCH 06/15] hw/pci-host/bonito: Use DeviceState::realize rather than SysBusDevice::init, Philippe Mathieu-Daudé, 2018/10/01
- Re: [Qemu-devel] [PATCH 06/15] hw/pci-host/bonito: Use DeviceState::realize rather than SysBusDevice::init,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH 08/15] hw/mips/gt64xxx_pci: Mark as bridge device, Philippe Mathieu-Daudé, 2018/10/01
- [Qemu-devel] [RFC PATCH 13/15] hw/alpha/typhoon: Remove unuseful code, Philippe Mathieu-Daudé, 2018/10/01
- [Qemu-devel] [RFC PATCH 15/15] hw/mips/malta: Remove unuseful code, Philippe Mathieu-Daudé, 2018/10/01
- [Qemu-devel] [PATCH 09/15] hw/mips/malta: Replace 'empty_slot' by 'unimplemented_device', Philippe Mathieu-Daudé, 2018/10/01