|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 2/3] cputlb: serialize tlb updates with env->tlb_lock |
Date: | Wed, 3 Oct 2018 19:05:51 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 03/10/2018 19:02, Emilio G. Cota wrote: >> For reads I agree, but you may actually get a torn read if the writer >> doesn't use atomic_set. > > But you cannot get a torn read if all reads that don't hold the lock > are coming from the same thread that performed the write. Ah, so you are relying on copy_tlb_helper(_locked) being invoked only from the vCPU thread (as opposed to someone else doing tlb_flush)? Maybe it's worth adding a comment if that's what I missed. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |