[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-nbd: Document --tls-creds
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-nbd: Document --tls-creds |
Date: |
Wed, 3 Oct 2018 16:35:35 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 10/03/2018 02:04 PM, Eric Blake wrote:
> Commit 145614a1 introduced --tls-creds, but forgot to document
> it in 'qemu-nbd --help'.
>
> Signed-off-by: Eric Blake <address@hidden>
>
> ---
> Sadly, 'git grep -i "qemu.nbd.*tls"' has no hits, making me wonder
> if our iotests are even covering this.
>
> Noticed while writing my other patches for defaulting to newstyle.
> ---
> qemu-nbd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index 51b9d38c727..66e023f7fa4 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -94,6 +94,7 @@ static void usage(const char *name)
> "General purpose options:\n"
> " --object type,id=ID,... define an object such as 'secret' for
> providing\n"
> " passwords and/or encryption keys\n"
> +" --tls-creds=ID use id of an earlier --object to provide TLS\n"
> " -T, --trace [[enable=]<pattern>][,events=<file>][,file=<file>]\n"
> " specify tracing options\n"
> " --fork fork off the server process and exit the
> parent\n"
>
Reviewed-by: John Snow <address@hidden>
Do we have a manpage/texi that needs to update, too?