qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 5/7] target/mips: Add availability control fo


From: Aleksandar Markovic
Subject: Re: [Qemu-devel] [PATCH v2 5/7] target/mips: Add availability control for DSP R3 ASE
Date: Mon, 8 Oct 2018 14:05:55 +0000

> From: Stefan Markovic <address@hidden>
>
> Add infrastructure for availability control for DSP R3 ASE MIPS
instructions. Only BPOSGE32C currently belongs to DSP R3 ASE, but
this is likely to be changed in near future.
>
> Signed-off-by: Aleksandar Markovic <address@hidden>

I think check_dspr3() should be check_dsp_r3(), but this will be then
inconsistent with  check_dspr3(). Consider a separate patch for refactoring
dsp r2/r3-related constant and function names. But that is beyond the scope
of this patch, so:

Reviewed-by: Aleksandar Markovic <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]