[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] accel: Improve selection of the default acceler
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator |
Date: |
Tue, 09 Oct 2018 11:05:49 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Peter Maydell <address@hidden> writes:
> On 5 October 2018 at 15:13, Thomas Huth <address@hidden> wrote:
>> When compiling with "--disable-tcg", we currently still use "tcg"
>> as default accelerator. "kvm" should be used in this case instead.
>
> This part is non-controversial and makes good sense.
Agreed.
>> Also, some downstream distros provide QEMU binaries which have "kvm"
>> in their names (e.g. "qemu-kvm" on RHEL or "kvm" on Ubuntu) that use
>> KVM by default - and some users might want to do something similar
>> with upstream binaries, too. Accomodate them by using "kvm:tcg" as
>> default when we detect such a binary name.
>
> This part is much riskier and less clearly a good plan --
> do we really want our behaviour to vary based on the name
> of the executable? Distros who want that sort of qemu-kvm
> wrapper generally are providing it already (the Ubuntu one
> is a 2-line shell script).
I hate it when argv[0] affects behavior[*]. I hate shell wrappers less.
If a system provides just one qemu executable, and its default
accelerator should be something other than tcg:kvm, then there's a use
for making it compile-time configurable. Reading the default from /etc/
would also work. Not sure such a system exists.
[*] Go document the behavior with proper precision, and you might come
to share the feeling.
- [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator, Thomas Huth, 2018/10/05
- Re: [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator, Cornelia Huck, 2018/10/05
- Re: [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator, Peter Maydell, 2018/10/05
- Re: [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator, Paolo Bonzini, 2018/10/05
- Re: [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator, Markus Armbruster, 2018/10/09
- Re: [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator, Thomas Huth, 2018/10/09
- Re: [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator, Daniel P . Berrangé, 2018/10/09
- Re: [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator, Cornelia Huck, 2018/10/09
- Re: [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator, Peter Maydell, 2018/10/09
- Re: [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator, Daniel P . Berrangé, 2018/10/09
- Re: [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator, Peter Maydell, 2018/10/09
- Re: [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator, Cornelia Huck, 2018/10/09
- Re: [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator, Paolo Bonzini, 2018/10/09
Re: [Qemu-devel] [PATCH] accel: Improve selection of the default accelerator, Philippe Mathieu-Daudé, 2018/10/05