[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/6] monitor: check if chardev can switch gcontext f
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH 4/6] monitor: check if chardev can switch gcontext for OOB |
Date: |
Tue, 9 Oct 2018 17:12:49 +0400 |
Note: this patch will conflict with Peter "[PATCH v9 3/6] monitor:
remove "x-oob", turn oob on by default", but can be trivially updated.
Signed-off-by: Marc-André Lureau <address@hidden>
---
monitor.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index a25514490a..c175cf6f0d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4550,9 +4550,10 @@ void monitor_init(Chardev *chr, int flags)
bool use_oob = flags & MONITOR_USE_OOB;
if (use_oob) {
- if (CHARDEV_IS_MUX(chr)) {
+ if (!qemu_chr_has_feature(chr, QEMU_CHAR_FEATURE_GCONTEXT)) {
error_report("Monitor out-of-band is not supported with "
- "MUX typed chardev backend");
+ "%s typed chardev backend",
+ object_get_typename(OBJECT(chr)));
exit(1);
}
if (use_readline) {
--
2.19.0.271.gfe8321ec05
- [Qemu-devel] [PATCH 0/6] monitor: misc fixes, Marc-André Lureau, 2018/10/09
- [Qemu-devel] [PATCH 1/6] monitor: inline ambiguous helper functions, Marc-André Lureau, 2018/10/09
- [Qemu-devel] [PATCH 2/6] monitor: accept chardev input from iothread, Marc-André Lureau, 2018/10/09
- [Qemu-devel] [PATCH 4/6] monitor: check if chardev can switch gcontext for OOB,
Marc-André Lureau <=
- [Qemu-devel] [PATCH 3/6] char: add a QEMU_CHAR_FEATURE_GCONTEXT flag, Marc-André Lureau, 2018/10/09
- [Qemu-devel] [PATCH 5/6] monitor: prevent inserting new monitors after cleanup, Marc-André Lureau, 2018/10/09
- [Qemu-devel] [PATCH 6/6] monitor: avoid potential dead-lock when cleaning up, Marc-André Lureau, 2018/10/09