[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] sdl2: Support all virtio-gpu formats
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] sdl2: Support all virtio-gpu formats |
Date: |
Wed, 10 Oct 2018 12:10:25 +0200 |
User-agent: |
NeoMutt/20180716 |
On Mon, Oct 08, 2018 at 08:50:13PM +0200, Max Reitz wrote:
> There are some 2D resource formats that can be used through virtio-gpu,
Ahem, not really. XRGB is the only one which works in practice, and
virtio-gpu kms driver will stop advertising anything else soon (patches
should land upstream with the next merge window).
> Add these formats in the switch converting pixman to SDL format
> constants so a guest cannot crash the VM by triggering the
> g_assert_not_reached() with an unsupported format.
Do you have a reproducer for that?
There is sdl2_2d_check_format() which reports the supported formats.
If we hit sdl2_2d_switch() with a format not whitelisted by
sdl2_2d_check_format() we have a bug somewhere in qemu ...
cheers,
Gerd