[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] tcg: fix use of uninitialized variable unde
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] tcg: fix use of uninitialized variable under CONFIG_PROFILER |
Date: |
Wed, 10 Oct 2018 17:14:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/10/2018 16:48, Emilio G. Cota wrote:
> We forgot to initialize n in commit 15fa08f845 ("tcg: Dynamically
> allocate TCGOps", 2017-12-29).
>
> Signed-off-by: Emilio G. Cota <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tcg/tcg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tcg/tcg.c b/tcg/tcg.c
> index f27b22bd3c..8f26916b99 100644
> --- a/tcg/tcg.c
> +++ b/tcg/tcg.c
> @@ -3430,7 +3430,7 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *tb)
>
> #ifdef CONFIG_PROFILER
> {
> - int n;
> + int n = 0;
>
> QTAILQ_FOREACH(op, &s->ops, link) {
> n++;
>
- [Qemu-devel] [PATCH 0/4] some TCG fixes, Emilio G. Cota, 2018/10/10
- [Qemu-devel] [PATCH 1/4] tcg: access cpu->icount_decr.u16.high with atomics, Emilio G. Cota, 2018/10/10
- [Qemu-devel] [PATCH 3/4] tcg: plug holes in struct TCGProfile, Emilio G. Cota, 2018/10/10
- [Qemu-devel] [PATCH 2/4] tcg: fix use of uninitialized variable under CONFIG_PROFILER, Emilio G. Cota, 2018/10/10
- Re: [Qemu-devel] [PATCH 2/4] tcg: fix use of uninitialized variable under CONFIG_PROFILER,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH 4/4] tcg: distribute tcg_time into TCG contexts, Emilio G. Cota, 2018/10/10
- Re: [Qemu-devel] [PATCH 0/4] some TCG fixes, Richard Henderson, 2018/10/11