[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] i386: pc_sysfw: load bios using rom API
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] i386: pc_sysfw: load bios using rom API |
Date: |
Thu, 11 Oct 2018 15:37:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 09/10/2018 07:55, Li Qiang wrote:
> As the bios is a ROM, just using rom API.
> AFAICS no functionality changed.
>
> Signed-off-by: Li Qiang <address@hidden>
> ---
ROM and RAM are just the same, with the readonly flag defaulting to
either true or false.
Because the alias here:
memory_region_init_alias(isa_bios, NULL, "isa-bios", bios,
bios_size - isa_bios_size, isa_bios_size);
if (!isapc_ram_fw) {
memory_region_set_readonly(isa_bios, true);
}
defaults to read-write (and your patch is wrong in changing the
direction of the if), it makes sense to do the same for the bios memory
region.
Thanks,
Paolo