[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 28/31] fsdev: Clean up error reporting in qemu_f
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 28/31] fsdev: Clean up error reporting in qemu_fsdev_add() |
|
Date: |
Thu, 11 Oct 2018 19:51:52 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 10/8/18 12:31 PM, Markus Armbruster wrote:
>> Calling error_report() from within a a function that takes an Error **
>
> s/a a/a/
Fixing, thanks!
>> argument is suspicious. qemu_fsdev_add() does that, and its caller
>> fsdev_init_func() then fails without setting an error. Its caller
>> main(), via qemu_opts_foreach(), is fine with it, but clean it up
>> anyway.
>>
- Re: [Qemu-devel] [PATCH 27/31] spice: Clean up error reporting in add_channel(), (continued)
- [Qemu-devel] [PATCH 10/31] smbios: Clean up error handling in smbios_add(), Markus Armbruster, 2018/10/08
- [Qemu-devel] [PATCH 13/31] net/socket: Fix invalid socket type error handling, Markus Armbruster, 2018/10/08
- [Qemu-devel] [PATCH 15/31] xen/pt: Fix incomplete conversion to realize(), Markus Armbruster, 2018/10/08
- [Qemu-devel] [PATCH 28/31] fsdev: Clean up error reporting in qemu_fsdev_add(), Markus Armbruster, 2018/10/08
- [Qemu-devel] [PATCH 07/31] 9pfs: Fix CLI parsing crash on error, Markus Armbruster, 2018/10/08
- [Qemu-devel] [PATCH 30/31] blockdev: Convert drive_new() to Error, Markus Armbruster, 2018/10/08