[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw: edu: drop DO_UPCAST
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] hw: edu: drop DO_UPCAST |
|
Date: |
Sat, 13 Oct 2018 10:09:53 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 13/10/2018 07:51, Li Qiang wrote:
> Signed-off-by: Li Qiang <address@hidden>
> ---
> hw/misc/edu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/misc/edu.c b/hw/misc/edu.c
> index 0687ffd343..cdcf550dd7 100644
> --- a/hw/misc/edu.c
> +++ b/hw/misc/edu.c
> @@ -342,7 +342,7 @@ static void *edu_fact_thread(void *opaque)
>
> static void pci_edu_realize(PCIDevice *pdev, Error **errp)
> {
> - EduState *edu = DO_UPCAST(EduState, pdev, pdev);
> + EduState *edu = EDU(pdev);
> uint8_t *pci_conf = pdev->config;
>
> pci_config_set_interrupt_pin(pci_conf, 1);
> @@ -365,7 +365,7 @@ static void pci_edu_realize(PCIDevice *pdev, Error **errp)
>
> static void pci_edu_uninit(PCIDevice *pdev)
> {
> - EduState *edu = DO_UPCAST(EduState, pdev, pdev);
> + EduState *edu = EDU(pdev);
>
> qemu_mutex_lock(&edu->thr_mutex);
> edu->stopping = true;
>
Queued, thanks.
Paolo