[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 08/21] accel/tcg/cputlb: convert remaining t
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH 08/21] accel/tcg/cputlb: convert remaining tlb_debug() to trace events |
|
Date: |
Mon, 15 Oct 2018 11:35:32 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/15/18 11:17 AM, Alex Bennée wrote:
>
> Richard Henderson <address@hidden> writes:
>
>> On 10/5/18 8:48 AM, Alex Bennée wrote:
>>> To avoid overly long lines in trace events I've split the event into
>>> tlb_set_page and tlb_set_page_attrs.
>>
>> I don't think this split is a good idea. It allows data from different
>> threads
>> to be interleaved.
>
> Won't we soon have a lock serialising this?
For each individual trace entry, surely.
If you split the trace in two, you leave a race in the middle.
> It was mainly to shut-up checkpatch because the trace-events don't seem
> to do multi-line.
I would just ignore that.
r~
- [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC, Alex Bennée, 2018/10/05
- [Qemu-devel] [RFC PATCH 04/21] trace: enable the exec_tb trace events, Alex Bennée, 2018/10/05
- [Qemu-devel] [RFC PATCH 01/21] util/log: allow -dfilter to stack, Alex Bennée, 2018/10/05
- [Qemu-devel] [RFC PATCH 05/21] trace: keep a count of trace-point hits, Alex Bennée, 2018/10/05
- [Qemu-devel] [RFC PATCH 18/21] linux-user: allow dumping of plugin status at end of run, Alex Bennée, 2018/10/05