[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of vi
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices |
Date: |
Tue, 16 Oct 2018 10:39:21 -0300 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Tue, Oct 16, 2018 at 08:48:16AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > I don't know. The `disable-modern` option already exists but I
> > don't know who would want to use it.
>
> Compat property for old (2.6 & older) machine types.
>
> > > Right - maybe a flag to disable modern interface is enough.
> > > We thus get two types:
> > > - transitional (legacy)
> > > - non-transitional (modern)
> > > which matches spec nicely.
> >
> > I would agree with the removal of virtio-*-0.9 only if we decide
> > to drop support for disable-modern=true.
>
> See above. We can't drop disable-modern.
Good point. But this doesn't require it to be a supported device
option for users/management. Maybe we should rename it to
"x-disable-modern" (but that's a separate discussion).
>
> > If we still want to provide a legacy-only virtio device, it should be
> > a separate device type.
>
> I can't see a reason why we should provide legacy-only virtio devices.
If the only reason for disable-modern to exist is for internal
usage by machine-type code, I agree we don't need the -0.9 device
types.
--
Eduardo
Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices, Gerd Hoffmann, 2018/10/15
Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices, Cornelia Huck, 2018/10/15
Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices, Stefan Hajnoczi, 2018/10/17