[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] archive-source.sh: Modern shell scripting (
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] archive-source.sh: Modern shell scripting (use $() instead of ``) |
Date: |
Mon, 15 Oct 2018 10:44:50 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/15/18 1:51 AM, Mao Zhongyi wrote:
Various shell files contain a mix between obsolete `` and
modern $(); use of `` is only required when using /bin/sh
on Solaris. It would be nice to convert to using $()
everywhere, or at least in all bash scripts, as well as in
all scripts that are known to not be run on Solaris.
Did you have a particular program you used to find these, or just grep?
Also, when sending a series, don't forget a 0/3 cover letter.
Signed-off-by: Mao Zhongyi <address@hidden>
---
scripts/archive-source.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org