[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 37/38] raw: Convert a warning to warn_report(
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 37/38] raw: Convert a warning to warn_report() |
Date: |
Wed, 17 Oct 2018 07:43:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 10/16/18 12:41 PM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> block/raw-format.c | 17 +++++++++--------
>> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> Incomplete. tests/qemu-iotests/109.out needs updating:
>
>> @@ -436,14 +437,14 @@ static int raw_open(BlockDriverState *bs, QDict
>> *options, int flags,
>> bs->file->bs->supported_zero_flags);
>> if (bs->probed && !bdrv_is_read_only(bs)) {
>> - fprintf(stderr,
>> - "WARNING: Image format was not specified for '%s' and
>> probing "
>> - "guessed raw.\n"
>> - " Automatically detecting the format is dangerous
>> for "
>> - "raw images, write operations on block 0 will be
>> restricted.\n"
>> - " Specify the 'raw' format explicitly to remove the
>> "
>> - "restrictions.\n",
>> - bs->file->bs->filename);
>> + warn_report("Image format was not specified for '%s' and probing "
>
> as this changes s/WARNING/warning/
Not run by "make check-block"... Will fix, thanks!
- [Qemu-devel] [PATCH v3 29/38] tpm: Clean up error reporting in tpm_init_tpmdev(), (continued)
- [Qemu-devel] [PATCH v3 29/38] tpm: Clean up error reporting in tpm_init_tpmdev(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 32/38] vl: Assert drive_new() does not fail in default_drive(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 38/38] vpc: Fail open on bad header checksum, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 24/38] vl: Clean up error reporting in device_init_func(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 21/38] vl: Clean up error reporting in machine_set_property(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 23/38] vl: Clean up error reporting in parse_fw_cfg(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 19/38] qom: Clean up error reporting in user_creatable_add_opts_foreach(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 17/38] seccomp: Clean up error reporting in parse_sandbox(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 37/38] raw: Convert a warning to warn_report(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 36/38] block: Clean up bdrv_img_create()'s error reporting, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 27/38] vnc: Clean up error reporting in vnc_init_func(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 26/38] ui: Convert vnc_display_init(), init_keyboard_layout() to Error, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 31/38] fsdev: Clean up error reporting in qemu_fsdev_add(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 35/38] vl: Simplify call of parse_name(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 25/38] ui/keymaps: Fix handling of erroneous include files, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 33/38] blockdev: Convert drive_new() to Error, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 30/38] spice: Clean up error reporting in add_channel(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 04/38] cpus hw target: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/16