[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 08/38] 9pfs: Fix CLI parsing crash on error
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH v3 08/38] 9pfs: Fix CLI parsing crash on error |
Date: |
Wed, 17 Oct 2018 09:15:16 +0200 |
On Tue, 16 Oct 2018 19:41:28 +0200
Markus Armbruster <address@hidden> wrote:
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. 9p-handle.c's handle_parse_opts() does that, and then
> fails without setting an error. Wrong. Its caller crashes when it
> tries to report the error:
>
> $ qemu-system-x86_64 -nodefaults -fsdev id=foo,fsdriver=handle
> qemu-system-x86_64: -fsdev id=foo,fsdriver=handle: warning: handle
> backend is deprecated
> qemu-system-x86_64: -fsdev id=foo,fsdriver=handle: fsdev: No path
> specified
> Segmentation fault (core dumped)
>
> Screwed up when commit 91cda4e8f37 (v2.12.0) converted the function to
> Error. Fix by calling error_setg() instead of error_report().
>
> Fixes: 91cda4e8f372602795e3a2f4bd2e3adaf9f82255
> Cc: Greg Kurz <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> Acked-by: Greg Kurz <address@hidden>
> ---
Hi Markus,
FWIW you had a Reviewed-by from Eric.
https://lists.nongnu.org/archive/html/qemu-devel/2018-10/msg03297.html
Cheers,
--
Greg
> hw/9pfs/9p-handle.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/9pfs/9p-handle.c b/hw/9pfs/9p-handle.c
> index f3641dbe4a..3465b1ef30 100644
> --- a/hw/9pfs/9p-handle.c
> +++ b/hw/9pfs/9p-handle.c
> @@ -19,6 +19,7 @@
> #include <grp.h>
> #include <sys/socket.h>
> #include <sys/un.h>
> +#include "qapi/error.h"
> #include "qemu/xattr.h"
> #include "qemu/cutils.h"
> #include "qemu/error-report.h"
> @@ -655,12 +656,13 @@ static int handle_parse_opts(QemuOpts *opts,
> FsDriverEntry *fse, Error **errp)
> warn_report("handle backend is deprecated");
>
> if (sec_model) {
> - error_report("Invalid argument security_model specified with handle
> fsdriver");
> + error_setg(errp,
> + "Invalid argument security_model specified with handle
> fsdriver");
> return -1;
> }
>
> if (!path) {
> - error_report("fsdev: No path specified");
> + error_setg(errp, "fsdev: No path specified");
> return -1;
> }
> fse->path = g_strdup(path);
- [Qemu-devel] [PATCH v3 00/38] Replace some unwise uses of error_report() & friends, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 12/38] migration: Fix !replay_can_snapshot() error handling, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 08/38] 9pfs: Fix CLI parsing crash on error, Markus Armbruster, 2018/10/16
- Re: [Qemu-devel] [PATCH v3 08/38] 9pfs: Fix CLI parsing crash on error,
Greg Kurz <=
- [Qemu-devel] [PATCH v3 09/38] pc: Fix machine property nvdimm-persistence error handling, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 05/38] vfio: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 01/38] error: Fix use of error_prepend() with &error_fatal, &error_abort, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 03/38] block: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 18/38] vl: Clean up error reporting in parse_add_fd(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 07/38] char: Use error_printf() to print help and such, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 20/38] vl: Clean up error reporting in chardev_init_func(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 10/38] ioapic: Fix error handling in realize(), Markus Armbruster, 2018/10/16