[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V6 3/5] target-i386: add rtc 0x70 port as coales
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH V6 3/5] target-i386: add rtc 0x70 port as coalesced_pio |
Date: |
Wed, 17 Oct 2018 12:31:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 17/10/2018 18:52, Peng Hao wrote:
> + /* register rtc 0x70 port as coalesced_pio */
> + memory_region_set_flush_coalesced(&s->io);
> + memory_region_init_io(&s->coalesced_io, OBJECT(s), &cmos_ops,
> + s, "rtc1", 1);
> + isa_register_ioport(isadev, &s->coalesced_io, base);
I think instead of isa_register_ioport you can use
memory_region_add_subregion, so that s->coalesced_io is added below s->io?
This way, you don't rely on the behavior of overlapping regions.
Paolo
> + memory_region_add_coalescing(&s->coalesced_io, 0, 1);
> +
[Qemu-devel] [PATCH V6 2/5] target-i386 : add coalesced_pio API, Peng Hao, 2018/10/17
[Qemu-devel] [PATCH V6 4/5] target-i386: add i440fx 0xcf8 port as coalesced_pio, Peng Hao, 2018/10/17