Re: [Qemu-devel] [PATCH] call HotplugHandler->plug() as the last step in device realization

[Paolo Bonzini]

On 16/10/2018 15:33, Igor Mammedov wrote:
> TODO:
>  remove usage of Error** from plug() callback, we need to factor out
>  pre_plug part from plug() callbacks, before proceeding with it.
>  DavidH has recently finished it for pc-dimm/memory_devices, cpus
>  mostly have pre_plug parts factored out, but there still are parts
>  that could fail so it needs some more work to eliminate failure points
>  from plug() callbacks. Meanwhile, I'll plan to treat other misc
>  handlers (pci[e]/acpi/usb/...) and introduce pre_plug() where
>  necessary.

I am not sure it's a good idea to do this first, rather than last (so
that we risk introducing a ping-pong of bugs that appear now and are
fixed when the other changes are made), but if others disagree I am okay
with the patch.

I agree that virtio-scsi is fine here.

Paolo