[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/21] tcg patch queue
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PULL 00/21] tcg patch queue |
Date: |
Thu, 18 Oct 2018 23:10:53 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/18/18 3:34 AM, Peter Maydell wrote:
> Hi; I get compile failures, I'm afraid:
>
> FreeBSD's compiler gives warnings:
> In file included from /var/tmp/qemu-test.bVaUEj/accel/tcg/user-exec.c:28:
> /var/tmp/qemu-test.bVaUEj/include/qemu/atomic128.h:148:23: warning:
> unknown attribute 'error' ignored [-Wunknown-attributes]
> Int128 __attribute__((error("unsupported atomic")))
> ^
> /var/tmp/qemu-test.bVaUEj/include/qemu/atomic128.h:150:21: warning:
> unknown attribute 'error' ignored [-Wunknown-attributes]
> void __attribute__((error("unsupported atomic")))
> ^
>
> x86-64 Linux clang fails with the same issue:
> In file included from
> /home/petmay01/linaro/qemu-for-merges/accel/tcg/user-exec.c:28:
> /home/petmay01/linaro/qemu-for-merges/include/qemu/atomic128.h:148:23:
> error: unknown attribute 'error' ignored
> [-Werror,-Wunknown-attributes]
> Int128 __attribute__((error("unsupported atomic")))
> ^
> /home/petmay01/linaro/qemu-for-merges/include/qemu/atomic128.h:150:21:
> error: unknown attribute 'error' ignored
> [-Werror,-Wunknown-attributes]
> void __attribute__((error("unsupported atomic")))
I used __has_attribute for this one. Tested with clang 7.
> The win32 build fails with:
>
> target/arm/helper-a64.o: In function `helper_paired_cmpxchg64_le_parallel':
> /home/petmay01/qemu-for-merges/target/arm/helper-a64.c:573: undefined
> reference to `helper_atomic_cmpxchgo_le_mmu'
> target/arm/helper-a64.o: In function `helper_paired_cmpxchg64_be_parallel':
> /home/petmay01/qemu-for-merges/target/arm/helper-a64.c:647: undefined
> reference to `helper_atomic_cmpxchgo_be_mmu'
> target/arm/helper-a64.o: In function `helper_casp_le_parallel':
> /home/petmay01/qemu-for-merges/target/arm/helper-a64.c:669: undefined
> reference to `helper_atomic_cmpxchgo_le_mmu'
> target/arm/helper-a64.o: In function `helper_casp_be_parallel':
> /home/petmay01/qemu-for-merges/target/arm/helper-a64.c:690: undefined
> reference to `helper_atomic_cmpxchgo_be_mmu'
This one I could not reproduce. Tested with i686-w64-mingw32-gcc
and x86_64-w64-mingw32-gcc, both version 6.2.
I suspect configure misfired. If you can, start this one over with a blank
build directory.
I've sent you a v2 pull.
r~
- [Qemu-devel] [PULL 06/21] target/alpha: remove tlb_flush from alpha_cpu_initfn, (continued)
- [Qemu-devel] [PULL 06/21] target/alpha: remove tlb_flush from alpha_cpu_initfn, Richard Henderson, 2018/10/16
- [Qemu-devel] [PULL 02/21] tcg: access cpu->icount_decr.u16.high with atomics, Richard Henderson, 2018/10/16
- [Qemu-devel] [PULL 17/21] target/s390x: Convert to HAVE_CMPXCHG128 and HAVE_ATOMIC128, Richard Henderson, 2018/10/16
- [Qemu-devel] [PULL 18/21] target/s390x: Split do_cdsg, do_lpq, do_stpq, Richard Henderson, 2018/10/16
- [Qemu-devel] [PULL 10/21] cputlb: serialize tlb updates with env->tlb_lock, Richard Henderson, 2018/10/16
- [Qemu-devel] [PULL 20/21] target/s390x: Check HAVE_ATOMIC128 and HAVE_CMPXCHG128 at translate, Richard Henderson, 2018/10/16
- [Qemu-devel] [PULL 11/21] tcg: Add tlb_index and tlb_entry helpers, Richard Henderson, 2018/10/16
- [Qemu-devel] [PULL 19/21] target/s390x: Skip wout, cout helpers if op helper does not return, Richard Henderson, 2018/10/16
- [Qemu-devel] [PULL 21/21] cputlb: read CPUTLBEntry.addr_write atomically, Richard Henderson, 2018/10/16
- Re: [Qemu-devel] [PULL 00/21] tcg patch queue, Peter Maydell, 2018/10/18
- Re: [Qemu-devel] [PULL 00/21] tcg patch queue,
Richard Henderson <=