[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 25/38] ui/keymaps: Fix handling of erroneous
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v4 25/38] ui/keymaps: Fix handling of erroneous include files |
Date: |
Fri, 19 Oct 2018 08:49:44 +0200 |
User-agent: |
NeoMutt/20180716 |
On Wed, Oct 17, 2018 at 10:26:49AM +0200, Markus Armbruster wrote:
> While errors in the keyboard layout named with -k are fatal, errors in
> included files are reported, but otherwise ignored:
>
> $ cat worst
> include bad
> include worse
> $ ls -l bad worse
> ls: cannot access 'bad': No such file or directory
> ls: cannot access 'worse': No such file or directory
> $ qemu-system-x86_64 -nodefaults -S -monitor stdio -display vnc=:0 -k bad
> QEMU 3.0.50 monitor - type 'help' for more information
> (qemu) Could not read keymap file: 'bad'
> $ qemu-system-x86_64 -nodefaults -S -monitor stdio -display vnc=:0 -k
> worst
> QEMU 3.0.50 monitor - type 'help' for more information
> (qemu) Could not read keymap file: 'bad'
> Could not read keymap file: 'worse'
>
> Fix that.
>
> Note that parse_keyboard_layout() allocates the keymap, except when
> it's parsing an include file. To keep error handling simple, move the
> memory management to its caller init_keyboard_layout().
>
> Cc: Gerd Hoffmann <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Gerd Hoffmann <address@hidden>
- [Qemu-devel] [PATCH v4 35/38] vl: Simplify call of parse_name(), (continued)
- [Qemu-devel] [PATCH v4 35/38] vl: Simplify call of parse_name(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 07/38] char: Use error_printf() to print help and such, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 31/38] fsdev: Clean up error reporting in qemu_fsdev_add(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 36/38] block: Clean up bdrv_img_create()'s error reporting, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 09/38] pc: Fix machine property nvdimm-persistence error handling, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 10/38] ioapic: Fix error handling in realize(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 17/38] seccomp: Clean up error reporting in parse_sandbox(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 05/38] vfio: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 25/38] ui/keymaps: Fix handling of erroneous include files, Markus Armbruster, 2018/10/17
- Re: [Qemu-devel] [PATCH v4 25/38] ui/keymaps: Fix handling of erroneous include files,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH v4 26/38] ui: Convert vnc_display_init(), init_keyboard_layout() to Error, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 04/38] cpus hw target: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 37/38] raw: Convert a warning to warn_report(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 38/38] vpc: Fail open on bad header checksum, Markus Armbruster, 2018/10/17