[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 30/38] spice: Clean up error reporting in add
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 30/38] spice: Clean up error reporting in add_channel() |
|
Date: |
Fri, 19 Oct 2018 08:53:05 +0200 |
|
User-agent: |
NeoMutt/20180716 |
On Wed, Oct 17, 2018 at 10:26:54AM +0200, Markus Armbruster wrote:
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. add_channel() does that, and then exit()s. Its caller
> main(), via qemu_opts_foreach(), is fine with it, but clean it up
> anyway.
>
> Cc: Gerd Hoffmann <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Gerd Hoffmann <address@hidden>
- [Qemu-devel] [PATCH v4 22/38] vl: Clean up error reporting in mon_init_func(), (continued)
- [Qemu-devel] [PATCH v4 22/38] vl: Clean up error reporting in mon_init_func(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 27/38] vnc: Clean up error reporting in vnc_init_func(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 21/38] vl: Clean up error reporting in machine_set_property(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 06/38] vfio: Clean up error reporting after previous commit, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 19/38] qom: Clean up error reporting in user_creatable_add_opts_foreach(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 23/38] vl: Clean up error reporting in parse_fw_cfg(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 24/38] vl: Clean up error reporting in device_init_func(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 28/38] numa: Clean up error reporting in parse_numa(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 30/38] spice: Clean up error reporting in add_channel(), Markus Armbruster, 2018/10/17
- Re: [Qemu-devel] [PATCH v4 30/38] spice: Clean up error reporting in add_channel(),
Gerd Hoffmann <=
- [Qemu-devel] [PATCH v4 33/38] blockdev: Convert drive_new() to Error, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 29/38] tpm: Clean up error reporting in tpm_init_tpmdev(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 32/38] vl: Assert drive_new() does not fail in default_drive(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 34/38] vl: Fix exit status for -drive format=help, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 35/38] vl: Simplify call of parse_name(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 07/38] char: Use error_printf() to print help and such, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 31/38] fsdev: Clean up error reporting in qemu_fsdev_add(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 36/38] block: Clean up bdrv_img_create()'s error reporting, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 09/38] pc: Fix machine property nvdimm-persistence error handling, Markus Armbruster, 2018/10/17