[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scripts: report on author emails that are mangl
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH] scripts: report on author emails that are mangled by the mailing list |
Date: |
Fri, 19 Oct 2018 12:22:50 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Copying Paolo, since this probably falls under the "misc patches"
maintainer bucket.
On Thu, Aug 23, 2018 at 11:25:02AM +0100, Daniel P. Berrangé wrote:
> In some cases the Author: email address in patches submitted to the
> list gets mangled such that it says
>
> John Doe via Qemu-devel <address@hidden>
>
> This change is a result of workarounds for DMARC policies.
>
> Subsystem maintainers accepting patches need to catch these and fix
> them before sending pull requests, so a checkpatch.pl test is highly
> desirable.
>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
> scripts/checkpatch.pl | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 42e1c50dd8..be2114a179 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1402,6 +1402,10 @@ sub process {
> $is_patch = 1;
> }
>
> + if ($line =~ /^Author: .*via Qemu-devel.*<address@hidden>/) {
> + ERROR("Author email address is mangled by the mailing
> list\n" . $herecurr);
> + }
> +
> #check the patch for a signoff:
> if ($line =~ /^\s*signed-off-by:/i) {
> # This is a signoff, if ugly, so do not double report.
> --
> 2.17.1
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [PATCH] scripts: report on author emails that are mangled by the mailing list,
Daniel P . Berrangé <=