[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v4 12/16] hw/arm/virt-acpi-build: Add PC-DIMM in S
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [RFC v4 12/16] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT |
Date: |
Mon, 22 Oct 2018 14:40:26 +0100 |
On Thu, 18 Oct 2018 16:30:38 +0200
Eric Auger <address@hidden> wrote:
> From: Shameer Kolothum <address@hidden>
>
> Generate Memory Affinity Structures for PC-DIMM ranges.
>
> Signed-off-by: Shameer Kolothum <address@hidden>
> Signed-off-by: Eric Auger <address@hidden>
>
> ---
> v3 -> v4:
> - do not use vms->bootinfo.device_memory_start/device_memory_size anymore
>
> v1 -> v2:
> - build_srat_hotpluggable_memory movedc to aml-build
> ---
> hw/arm/virt-acpi-build.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index 5785fb697c..8818bbf5ec 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -545,6 +545,7 @@ build_srat(GArray *table_data, BIOSLinker *linker,
> VirtMachineState *vms)
> int i, srat_start;
> uint64_t mem_base;
> MachineClass *mc = MACHINE_GET_CLASS(vms);
> + MachineState *ms = MACHINE(vms);
> const CPUArchIdList *cpu_list = mc->possible_cpu_arch_ids(MACHINE(vms));
>
> srat_start = table_data->len;
> @@ -570,6 +571,9 @@ build_srat(GArray *table_data, BIOSLinker *linker,
> VirtMachineState *vms)
> }
> }
>
> + build_srat_hotpluggable_memory(table_data, ms->device_memory->base,
> + ms->device_memory->mr.size, 0);
on x86, we use the last node here to make windows happy. I'd use the same value
here.
> +
> build_header(linker, table_data, (void *)(table_data->data + srat_start),
> "SRAT", table_data->len - srat_start, 3, NULL, NULL);
> }
- [Qemu-devel] [RFC v4 03/16] hw/boards: Add a MachineState parameter to kvm_type callback, (continued)
- [Qemu-devel] [RFC v4 03/16] hw/boards: Add a MachineState parameter to kvm_type callback, Eric Auger, 2018/10/18
- [Qemu-devel] [RFC v4 04/16] kvm: add kvm_arm_get_max_vm_phys_shift, Eric Auger, 2018/10/18
- [Qemu-devel] [RFC v4 05/16] vl: Set machine ram_size, maxram_size and ram_slots earlier, Eric Auger, 2018/10/18
- [Qemu-devel] [RFC v4 08/16] hw/arm/virt: Allocate device_memory, Eric Auger, 2018/10/18
- [Qemu-devel] [RFC v4 07/16] hw/arm/virt: Implement kvm_type function for 3.2 machine, Eric Auger, 2018/10/18
- [Qemu-devel] [RFC v4 09/16] hw/arm/virt: Add memory hotplug framework, Eric Auger, 2018/10/18
- [Qemu-devel] [RFC v4 10/16] hw/arm/boot: Expose the PC-DIMM nodes in the DT, Eric Auger, 2018/10/18
- [Qemu-devel] [RFC v4 12/16] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT, Eric Auger, 2018/10/18
- Re: [Qemu-devel] [RFC v4 12/16] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT,
Igor Mammedov <=
- [Qemu-devel] [RFC v4 11/16] acpi: move build_srat_hotpluggable_memory to generic ACPI source, Eric Auger, 2018/10/18
- [Qemu-devel] [RFC v4 13/16] nvdimm: use configurable ACPI IO base and size, Eric Auger, 2018/10/18
- [Qemu-devel] [RFC v4 15/16] hw/arm/boot: Expose the pmem nodes in the DT, Eric Auger, 2018/10/18
- [Qemu-devel] [RFC v4 14/16] hw/arm/virt: Add nvdimm hot-plug infrastructure, Eric Auger, 2018/10/18
- [Qemu-devel] [RFC v4 16/16] hw/arm/virt: Add nvdimm and nvdimm-persistence options, Eric Auger, 2018/10/18