[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1] arm: check bit index before usage
From: |
P J P |
Subject: |
Re: [Qemu-devel] [PATCH v1] arm: check bit index before usage |
Date: |
Tue, 23 Oct 2018 10:21:13 +0530 (IST) |
+-- On Tue, 23 Oct 2018, Philippe Mathieu-Daudé wrote --+
| > From: Prasad J Pandit <address@hidden>
| >
| > Update v1: use ARRAY_SIZE macro
| > -> https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg04826.html
| >
| > - qemu_set_irq(s->handler[bit], (level >> bit) & 1);
| > + if (bit < ARRAY_SIZE(s->handler)) {
| > + qemu_set_irq(s->handler[bit], (level >> bit) & 1);
|
| } else {
| qemu_log_mask(LOG_GUEST_ERROR, ...
|
| With that:
| Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Thank you Philippe and Li.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F