[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/7] decodetree: Remove "insn" argument from tra
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 2/7] decodetree: Remove "insn" argument from trans_* expanders |
Date: |
Tue, 23 Oct 2018 14:08:37 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/23/18 2:04 PM, Bastian Koppelmann wrote:
> On 10/23/18 2:04 PM, Richard Henderson wrote:
>> ??? Needs simultaneous corresponding changes to all
>> translators using decodetree.
>> ---
>> scripts/decodetree.py | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>
> Was the only intend of the insn argument to be used for manual decoding in a
> trans_ function?
I didn't quite know what it might be used for, and thought I was planning
ahead. Now I see that it's probably counter-productive.
In particular, think of how you were calling the trans_foo functions yourself,
passing along the uint16_t input to the uint32_t output. Which would have
worked not at all had you actually been using it for decode within the insn32
code base.
r~
- [Qemu-devel] [PATCH 4/7] target/riscv: Rename some argument sets in insn32.decode, (continued)
[Qemu-devel] [PATCH 5/7] target/riscv: Convert @cs_2 insns to share translation functions, Richard Henderson, 2018/10/23
[Qemu-devel] [PATCH 6/7] target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns, Richard Henderson, 2018/10/23
[Qemu-devel] [PATCH 3/7] target/riscv: Update for decodetree insn argument change, Richard Henderson, 2018/10/23