[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH 05/10] docs/devel/testing.rst: ad
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH 05/10] docs/devel/testing.rst: add missing newlines after code block |
Date: |
Thu, 25 Oct 2018 14:59:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/10/2018 17:18, Cleber Rosa wrote:
> The line immediate following a ".. code::" block is considered
> to contains arguments to the "code directive". The lack of a
> new line gives me during at parse time:
>
> testing.rst:63: (ERROR/3) Error in "code" directive:
> maximum 1 argument(s) allowed, 3 supplied.
>
> .. code::
> make check-unit V=1
>
> testing.rst:120: (ERROR/3) Error in "code" directive:
> maximum 1 argument(s) allowed, 3 supplied.
>
> .. code::
> make check-qtest V=1
>
> Let's add the missing newlines, both for consistency and to
> avoid the parsing errors.
>
> Signed-off-by: Cleber Rosa <address@hidden>
> ---
> docs/devel/testing.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
> index 727c4019b5..9355ad49f2 100644
> --- a/docs/devel/testing.rst
> +++ b/docs/devel/testing.rst
> @@ -61,6 +61,7 @@ variable (which affects memory reclamation and catches
> invalid pointers better)
> and gtester options. If necessary, you can run
>
> .. code::
> +
> make check-unit V=1
>
> and copy the actual command line which executes the unit test, then run
> @@ -118,6 +119,7 @@ and using gdb on the test is still simple to do: find out
> the actual command
> from the output of
>
> .. code::
> +
> make check-qtest V=1
>
> which you can run manually.
>
Applied
Thanks,
Laurent
[Qemu-devel] [PATCH 05/10] docs/devel/testing.rst: add missing newlines after code block, Cleber Rosa, 2018/10/04
[Qemu-devel] [PATCH 06/10] thunk.c: clean up commented out definition, Cleber Rosa, 2018/10/04
[Qemu-devel] [PATCH 04/10] qemu-iotests: fix filename containing checks, Cleber Rosa, 2018/10/04
[Qemu-devel] [PATCH 07/10] scripts/decodetree.py: remove unused imports, Cleber Rosa, 2018/10/04