Re: [Qemu-devel] [PATCH 2/3] adlib: mark as insecure and deprecated.

[P J P]

+-- On Fri, 26 Oct 2018, Paolo Bonzini wrote --+
| Oh, thanks!  I said I was dumb. :)  So the fix is just this:
| 
| diff --git a/hw/audio/fmopl.h b/hw/audio/fmopl.h
| index e7e578a48e..7199afaa3c 100644
| --- a/hw/audio/fmopl.h
| +++ b/hw/audio/fmopl.h
| @@ -72,8 +72,8 @@ typedef struct fm_opl_f {
|       /* Rhythm sention */
|       uint8_t rhythm;         /* Rhythm mode , key flag */
|       /* time tables */
| -     int32_t AR_TABLE[75];   /* atttack rate tables */
| -     int32_t DR_TABLE[75];   /* decay rate tables   */
| +     int32_t AR_TABLE[76];   /* atttack rate tables */
| +     int32_t DR_TABLE[76];   /* decay rate tables   */
|       uint32_t FN_TABLE[1024];  /* fnumber -> increment counter */
|       /* LFO */
|       int32_t *ams_table;
| 
| and init_timetables will just fill it with the right value?  (I checked
| against another implementation at http://opl3.cozendey.com/).

Gerd has proposed to a patch to deprecate adlib, as it's not used as much. IMO 
deprecation is better option. But if that is not happening, above seems good.

Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F