[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v4 07/71] tcg-runtime: define helper_cpu_halted_se
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [RFC v4 07/71] tcg-runtime: define helper_cpu_halted_set |
Date: |
Fri, 26 Oct 2018 15:57:07 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/25/18 3:45 PM, Emilio G. Cota wrote:
> +void HELPER(cpu_halted_set)(CPUArchState *env, uint32_t val)
> +{
> + CPUState *cpu = ENV_GET_CPU(env);
> +
> + cpu->halted = val;
> +}
I suppose this is fine as a first step. I'd like to clean up all of the
targets to also use a helper like this to also raise EXCP_HALTED. They all
perform the same actions, even though this isn't obvious (many of them
reuse helpers that also raise target-specific exceptions).
That said,
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [RFC v4 19/71] i386: convert to cpu_halted, (continued)
- [Qemu-devel] [RFC v4 19/71] i386: convert to cpu_halted, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 15/71] tcg-runtime: convert to cpu_halted_set, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 09/71] cris: convert to helper_cpu_halted_set, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 13/71] microblaze: convert to helper_cpu_halted_set, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 08/71] ppc: convert to helper_cpu_halted_set, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 07/71] tcg-runtime: define helper_cpu_halted_set, Emilio G. Cota, 2018/10/25
- Re: [Qemu-devel] [RFC v4 07/71] tcg-runtime: define helper_cpu_halted_set,
Richard Henderson <=
- [Qemu-devel] [RFC v4 05/71] cpu: move run_on_cpu to cpus-common, Emilio G. Cota, 2018/10/25
[Qemu-devel] [RFC v4 02/71] cpu: rename cpu->work_mutex to cpu->lock, Emilio G. Cota, 2018/10/25
[Qemu-devel] [RFC v4 39/71] i386/hax-all: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/25
[Qemu-devel] [RFC v4 06/71] cpu: introduce process_queued_cpu_work_locked, Emilio G. Cota, 2018/10/25