|
From: | Hervé Poussineau |
Subject: | Re: [Qemu-devel] [PATCH v5 06/11] esp: add pseudo-DMA as used by Macintosh |
Date: | Tue, 30 Oct 2018 07:47:09 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit :
From: Laurent Vivier <address@hidden> Co-developed-by: Mark Cave-Ayland <address@hidden> Signed-off-by: Mark Cave-Ayland <address@hidden> Signed-off-by: Laurent Vivier <address@hidden> --- hw/scsi/esp.c | 292 +++++++++++++++++++++++++++++++++++++++++++++----- include/hw/scsi/esp.h | 7 ++ 2 files changed, 270 insertions(+), 29 deletions(-)
[...]
@@ -409,6 +564,7 @@ uint64_t esp_reg_read(ESPState *s, uint32_t saddr)s->ti_size--; s->rregs[ESP_FIFO] = s->ti_buf[s->ti_rptr++]; } + esp_raise_irq(s); if (s->ti_rptr == s->ti_wptr) { s->ti_rptr = 0; s->ti_wptr = 0;
You're now raising irq (not drq) when reading registers. In my opinion, this deserves its own patch with an explanation. Hervé
[Prev in Thread] | Current Thread | [Next in Thread] |