[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] configure: symlink directories, not wildcar
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] configure: symlink directories, not wildcarded files |
Date: |
Tue, 30 Oct 2018 13:08:13 +0000 |
On 30 October 2018 at 13:01, Peter Maydell <address@hidden> wrote:
> ...having sent this out and moved on to something else, I have
> discovered a problem with it. If you configure a build tree
> using this, and then switch back to a git branch which has
> the older configure, then that configure will end up trashing
> all the tests/acpi-test-data and tests/hex-loader-check-data
> files in the source tree by replacing them with symlinks to
> themselves... This is fixable by doing "git checkout tests"
> but it's a bit of a landmine for bisection :-(
Maybe we should standardize on having all data files for tests
be in tests/data, which is and has always been a symlink to
a directory. That would avoid this problem with old versions
of configure mangling the source directory by accident.
thanks
-- PMM
- [Qemu-devel] [PATCH 0/3] configure: symlink directories, not wildcarded files, Peter Maydell, 2018/10/30
- [Qemu-devel] [PATCH 3/3] configure: Use FILES loop for all build tree symlinks, Peter Maydell, 2018/10/30
- [Qemu-devel] [PATCH 2/3] configure: Symlink entire test directories rather than individual files, Peter Maydell, 2018/10/30
- [Qemu-devel] [PATCH 1/3] configure: Rename FILES variable to LINKS, Peter Maydell, 2018/10/30
- Re: [Qemu-devel] [PATCH 0/3] configure: symlink directories, not wildcarded files, Peter Maydell, 2018/10/30
- Re: [Qemu-devel] [PATCH 0/3] configure: symlink directories, not wildcarded files,
Peter Maydell <=