[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/2] hw: fw_cfg: ensure reboot_time is nonegative
From: |
Li Qiang |
Subject: |
[Qemu-devel] [PATCH 1/2] hw: fw_cfg: ensure reboot_time is nonegative |
Date: |
Wed, 31 Oct 2018 23:09:54 -0700 |
This can avoid setting a negative value to
etc/boot-fail-wait.
Signed-off-by: Li Qiang <address@hidden>
---
hw/nvram/fw_cfg.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 3fcfa35..dff6e06 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -199,12 +199,17 @@ static void fw_cfg_reboot(FWCfgState *s)
reboot_timeout = strtol(p, &p, 10);
}
}
- /* validate the input */
- if (reboot_timeout > 0xffff) {
- error_report("reboot timeout is larger than 65535, force it to
65535.");
- reboot_timeout = 0xffff;
+
+ if (reboot_timeout >= 0) {
+ /* validate the input */
+ if (reboot_timeout > 0xffff) {
+ error_report("reboot timeout is larger than 65535,"
+ "force it to 65535.");
+ reboot_timeout = 0xffff;
+ }
+ fw_cfg_add_file(s, "etc/boot-fail-wait",
+ g_memdup(&reboot_timeout, 4), 4);
}
- fw_cfg_add_file(s, "etc/boot-fail-wait", g_memdup(&reboot_timeout, 4), 4);
}
static void fw_cfg_write(FWCfgState *s, uint8_t value)
--
1.8.3.1
- [Qemu-devel] [PATCH 1/2] hw: fw_cfg: ensure reboot_time is nonegative,
Li Qiang <=