qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 for-3.1 1/4] tests: Move tests/acpi-test-data


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH v2 for-3.1 1/4] tests: Move tests/acpi-test-data/ to tests/data/acpi/
Date: Fri, 2 Nov 2018 19:00:54 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 2/11/18 18:42, Peter Maydell wrote:
On 2 November 2018 at 17:38, Philippe Mathieu-Daudé <address@hidden> wrote:
Hi Peter,

On 2/11/18 12:52, Peter Maydell wrote:
We can remove entirely the note in rebuild-expected-aml.sh
about copying any new data files, because now they will
be in the source directory, not the build directory, and
no copying is required.


This doesn't seem true for out-of-tree builds.

In the old setup, running the rebuild-expected-aml.sh
script is done in the build directory, and creates new
data files in ./tests/acpi-test-data/, which must then be
copied to the source directory.
In the new setup, the script is still run in the build
directory, but when new data files are created in
./tests/data/acpi/ they don't need to be copied anywhere,
because the directory symlink means they're already in
tests/data/acpi in the source directory structure.

Oh you are correct...
My other terminal output was not update and was displaying the inodes from a previous run. No problem then!

Thanks,

Phil.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]