[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] memory-mapping: skip non-volatile memory re
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] memory-mapping: skip non-volatile memory regions in GuestPhysBlockList |
Date: |
Mon, 5 Nov 2018 16:17:09 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 10/29/18 10:50, Paolo Bonzini wrote:
> On 03/10/2018 13:44, Marc-André Lureau wrote:
>> diff --git a/memory_mapping.c b/memory_mapping.c
>> index 775466f3a8..724dd0b417 100644
>> --- a/memory_mapping.c
>> +++ b/memory_mapping.c
>> @@ -206,7 +206,8 @@ static void guest_phys_blocks_region_add(MemoryListener
>> *listener,
>>
>> /* we only care about RAM */
>> if (!memory_region_is_ram(section->mr) ||
>> - memory_region_is_ram_device(section->mr)) {
>> + memory_region_is_ram_device(section->mr) ||
>> + memory_region_is_nonvolatile(section->mr)) {
>> return;
>> }
>>
>
> We should also have
>
> diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py
> index 5a857cebcf..dd180b531c 100644
> --- a/scripts/dump-guest-memory.py
> +++ b/scripts/dump-guest-memory.py
> @@ -417,7 +417,9 @@ def get_guest_phys_blocks():
> memory_region = flat_range["mr"].dereference()
>
> # we only care about RAM
> - if not memory_region["ram"]:
> + if not memory_region["ram"] \
> + or memory_region["ram_device"] \
> + or memory_region["nonvolatile"]:
> continue
>
> section_size = int128_get64(flat_range["addr"]["size"])
>
> here. I queued the patches and will post this soon as a separate patch.
Thanks. I keep forgetting that this logic is duplicated.
Laszlo
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 3/3] memory-mapping: skip non-volatile memory regions in GuestPhysBlockList,
Laszlo Ersek <=