qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] List of files containing devices which have not been QO


From: Paolo Bonzini
Subject: Re: [Qemu-devel] List of files containing devices which have not been QOMified
Date: Tue, 6 Nov 2018 22:26:40 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0

On 06/11/2018 22:23, John Snow wrote:
> 
> 
> On 11/06/2018 02:46 PM, Paolo Bonzini wrote:
>> On 06/11/2018 19:43, Peter Maydell wrote:
> 
>>> hw/ide/ahci.c
>>
>> Even though AHCIState is not a QOM object, all of its users are
>> (TYPE_SYSBUS_AHCI is in this file, TYPE_ICH9_AHCI is in hw/ide/ich.c).
> 
> Yeah, if there's something *further* that needs to happen, let me know.
> I'm not sure what the QOM ideal is.

I think it's okay.  The virtio-*-device approach (which is contained in
virtio-*-pci and virtio-*-ccw) made sense for virtio where you could
have "socket" virtio-mmio devices and the virtio-*-device "plugs" are
specified in the command line.  However, for AHCI it's overkill.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]