[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.1 3/4] slirp: Remove code that handles soc
|
From: |
Samuel Thibault |
|
Subject: |
Re: [Qemu-devel] [PATCH for-3.1 3/4] slirp: Remove code that handles socreate() failure |
|
Date: |
Wed, 7 Nov 2018 00:08:50 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
Peter Maydell, le mar. 06 nov. 2018 15:13:22 +0000, a ecrit:
> Now that socreate() can never fail, we can remove the code
> that was trying to handle that situation.
>
> In particular this removes code in tcp_connect() that
> provoked Coverity to complain (CID 1005724): in
> closesocket(accept(inso->s, (struct sockaddr *)&addr, &addrlen));
> if the accept() call fails then we pass closesocket() -1
> instead of a valid file descriptor.
>
> Signed-off-by: Peter Maydell <address@hidden>
Applied, thanks!