[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on o
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions |
Date: |
Wed, 7 Nov 2018 13:45:35 +0000 |
On 7 November 2018 at 12:49, Eduardo Habkost <address@hidden> wrote:
> Now, why do we need --with-python, and why do we need to use
> $(PYTHON) when running tests? If somebody wants to use a
> different Python binary when running tests, they can already use
> $PATH for that.
>
> (That's the same argument I used for iotests a while ago:
> https://www.mail-archive.com/address@hidden/msg566631.html)
I'm not a great fan of requiring the user to mess with their PATH
to get configure to work. Also, the first python on the path
might be the wrong one, and we don't pass PATH from configure
to make so you end up having to make sure you specify it
right in both places.
Plus we already have --with-python, so if you want to drop
it you need to deprecate it first, and you need a justification
that's strong enough to outweigh breaking users' existing
build/packaging setups and scripts...
thanks
-- PMM
- Re: [Qemu-devel] [PULL 11/15] Bootstrap Python venv for tests, Peter Maydell, 2018/11/06
- Re: [Qemu-devel] [PULL 11/15] Bootstrap Python venv for tests, Philippe Mathieu-Daudé, 2018/11/06
- [Qemu-devel] [PATCH] tests: Fix Python 3 detection on older GNU make versions, Eduardo Habkost, 2018/11/06
- Re: [Qemu-devel] [PATCH] tests: Fix Python 3 detection on older GNU make versions, Peter Maydell, 2018/11/06
- Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions, Markus Armbruster, 2018/11/07
- Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions, Peter Maydell, 2018/11/07
- Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions, Eduardo Habkost, 2018/11/07
- Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions,
Peter Maydell <=
- Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions, Eduardo Habkost, 2018/11/07
- Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions, Markus Armbruster, 2018/11/07
- Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions, Cleber Rosa, 2018/11/07
- Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions, Markus Armbruster, 2018/11/08
- Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions, Philippe Mathieu-Daudé, 2018/11/08
- Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions, Markus Armbruster, 2018/11/08
- Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions, Max Reitz, 2018/11/09
- Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions, Markus Armbruster, 2018/11/12
- Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions, Cleber Rosa, 2018/11/08
- Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions, Eduardo Habkost, 2018/11/08