[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 00/13] arm: nRF51 Devices and Microbit Suppor
From: |
Joel Stanley |
Subject: |
Re: [Qemu-devel] [PATCH v4 00/13] arm: nRF51 Devices and Microbit Support |
Date: |
Thu, 8 Nov 2018 20:50:23 +1030 |
On Thu, 8 Nov 2018 at 20:12, Peter Maydell <address@hidden> wrote:
>
> On 8 November 2018 at 09:32, Stefan Hajnoczi <address@hidden> wrote:
> > On Fri, Nov 02, 2018 at 01:07:17PM -0400, Steffen Görtz wrote:
> >
> > Thank you, Steffen! I have posted my Reviewed-by on all patches.
> >
> > Joel: Will you send pull requests for the microbit machine types or do
> > you want Peter to merge this?
>
> I had some code review comments (mostly minor, but there's
> a definite bug in the timer code) that need addressing
> before this series can be merged. It's pretty close, though.
I'm not fussed if I send the request or Peter does. For the aspeed
work I've done in the past Peter has rolled the patches into his ARM
pull requests.
Peter, once the patches are good to go, what would you prefer?
Cheers,
Joel
- Re: [Qemu-devel] [PATCH v4 11/13] hw/timer/nrf51_timer: Add nRF51 Timer peripheral, (continued)
- [Qemu-devel] [PATCH v4 12/13] arm: Instantiate NRF51 Timers, Steffen Görtz, 2018/11/02
- Re: [Qemu-devel] [PATCH v4 00/13] arm: nRF51 Devices and Microbit Support, no-reply, 2018/11/04
- Re: [Qemu-devel] [PATCH v4 00/13] arm: nRF51 Devices and Microbit Support, no-reply, 2018/11/04
- Re: [Qemu-devel] [PATCH v4 00/13] arm: nRF51 Devices and Microbit Support, no-reply, 2018/11/06
- Re: [Qemu-devel] [PATCH v4 00/13] arm: nRF51 Devices and Microbit Support, no-reply, 2018/11/06
- Re: [Qemu-devel] [PATCH v4 00/13] arm: nRF51 Devices and Microbit Support, Stefan Hajnoczi, 2018/11/08
- Re: [Qemu-devel] [PATCH v4 00/13] arm: nRF51 Devices and Microbit Support, no-reply, 2018/11/08
- Re: [Qemu-devel] [PATCH v4 00/13] arm: nRF51 Devices and Microbit Support, no-reply, 2018/11/08