qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tcg/tcg-op.h: Add multiple include guard


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH] tcg/tcg-op.h: Add multiple include guard
Date: Thu, 8 Nov 2018 15:08:59 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 8/11/18 14:17, Peter Maydell wrote:
On 8 November 2018 at 13:08, Philippe Mathieu-Daudé <address@hidden> wrote:
On 8/11/18 13:52, Peter Maydell wrote:

The tcg-op.h header was missing the usual guard against multiple
inclusion; add it.

(Spotted by lgtm.com's static analyzer.)


I'm pretty sure there are more occurences.

The only other ones the analyzer spotted all seemed to be
"deliberately multiply included" (like
include/exec/memory_ldst_phys.inc.h), though we don't in
all cases use the ".inc.h" convention that sort-of
indicates that).

https://lgtm.com/projects/g/qemu/qemu/alerts/?mode=tree
is probably the most convenient url if you want to
go looking for other stuff. Some of its issues are
definitely false-positives, but there may be some other
easy to fix things in there (eg the "local variable
hides global variable" ones -- though if we care about
these we should enable -Wshadow and fix the compile
failures).

Notably, lgtm does checks on python, which Coverity does not,
so that is more likely to be a source of real issues to fix,
I think.

Thanks for the pointer.

This stats are funny^H^H^H^Hscary:
https://lgtm.com/blog/best_email_domain#What%20about%20the%20free%20email%20providers?


thanks
-- PMM




reply via email to

[Prev in Thread] Current Thread [Next in Thread]