[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/6] tests/guest-debug: fix scoping of failco
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/6] tests/guest-debug: fix scoping of failcount |
Date: |
Thu, 8 Nov 2018 18:14:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 11/8/18 5:33 PM, Alex Bennée wrote:
> @@ -16,6 +16,7 @@ def report(cond, msg):
> print ("PASS: %s" % (msg))
> else:
> print ("FAIL: %s" % (msg))
> + global failcount
> failcount += 1
Do we usually prefer such declarations at the start of the function?
Anyway,
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v2 0/6] KVM Guest Debug fixes (plus TCG EL2 debug tweaks), Alex Bennée, 2018/11/08
- [Qemu-devel] [PATCH v2 3/6] target/arm64: kvm debug set target_el when passing exception to guest, Alex Bennée, 2018/11/08
- [Qemu-devel] [PATCH v2 5/6] arm: use symbolic MDCR_TDE in arm_debug_target_el, Alex Bennée, 2018/11/08
- [Qemu-devel] [PATCH v2 4/6] tests/guest-debug: fix scoping of failcount, Alex Bennée, 2018/11/08
- Re: [Qemu-devel] [PATCH v2 4/6] tests/guest-debug: fix scoping of failcount,
Richard Henderson <=
- [Qemu-devel] [PATCH v2 6/6] arm: fix aa64_generate_debug_exceptions to work with EL2, Alex Bennée, 2018/11/08
- [Qemu-devel] [PATCH v2 2/6] target/arm64: hold BQL when calling do_interrupt(), Alex Bennée, 2018/11/08
- [Qemu-devel] [PATCH v2 1/6] target/arm64: properly handle DBGVR RESS bits, Alex Bennée, 2018/11/08