[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 3/9] qapi: use qemu_strtod_finite() in string
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v1 3/9] qapi: use qemu_strtod_finite() in string-input-visitor |
Date: |
Thu, 15 Nov 2018 15:39:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 15.11.18 15:37, Eric Blake wrote:
> On 11/15/18 8:04 AM, David Hildenbrand wrote:
>> Let's use the new function. "NaN" and "inf" are now properly rejected.
>>
>> Signed-off-by: David Hildenbrand <address@hidden>
>> ---
>> qapi/string-input-visitor.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> Reviewed-by: Eric Blake <address@hidden>
>
> Should there be any added test coverage in this patch, or is it later in
> the series?
Nope not yet, but can add.
--
Thanks,
David / dhildenb
- Re: [Qemu-devel] [PATCH v1 1/9] cutils: add qemu_strtod() and qemu_strtod_finite(), (continued)
[Qemu-devel] [PATCH v1 2/9] cutils: use qemu_strtod_finite() in do_strtosz(), David Hildenbrand, 2018/11/15
[Qemu-devel] [PATCH v1 3/9] qapi: use qemu_strtod_finite() in string-input-visitor, David Hildenbrand, 2018/11/15
[Qemu-devel] [PATCH v1 4/9] qapi: use qemu_strtod_finite() in qobject-input-visitor, David Hildenbrand, 2018/11/15
[Qemu-devel] [PATCH v1 7/9] test-string-input-visitor: use virtual walk, David Hildenbrand, 2018/11/15
[Qemu-devel] [PATCH v1 5/9] test-string-input-visitor: add more tests, David Hildenbrand, 2018/11/15