[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 15/16] gdbstub: add multiprocess extension su
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH v6 15/16] gdbstub: add multiprocess extension support |
Date: |
Fri, 16 Nov 2018 11:14:38 +0100 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Thu, Nov 15, 2018 at 10:42:06AM +0100, Luc Michel wrote:
> Add multiprocess extension support by enabling multiprocess mode when
> the peer requests it, and by replying that we actually support it in the
> qSupported reply packet.
>
> Signed-off-by: Luc Michel <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Acked-by: Alistair Francis <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
> ---
> gdbstub.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 89819a6a72..e0b844c040 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1721,10 +1721,16 @@ static int gdb_handle_packet(GDBState *s, const char
> *line_buf)
> snprintf(buf, sizeof(buf), "PacketSize=%x", MAX_PACKET_LENGTH);
> cc = CPU_GET_CLASS(first_cpu);
> if (cc->gdb_core_xml_file != NULL) {
> pstrcat(buf, sizeof(buf), ";qXfer:features:read+");
> }
> +
> + if (strstr(p, "multiprocess+")) {
> + s->multiprocess = true;
> + }
> + pstrcat(buf, sizeof(buf), ";multiprocess+");
> +
> put_packet(s, buf);
> break;
> }
> if (strncmp(p, "Xfer:features:read:", 19) == 0) {
> const char *xml;
> --
> 2.19.1
>
- [Qemu-devel] [PATCH v6 03/16] gdbstub: add multiprocess support to '?' packets, (continued)
- [Qemu-devel] [PATCH v6 03/16] gdbstub: add multiprocess support to '?' packets, Luc Michel, 2018/11/15
- [Qemu-devel] [PATCH v6 10/16] gdbstub: add multiprocess support to 'D' packets, Luc Michel, 2018/11/15
- [Qemu-devel] [PATCH v6 09/16] gdbstub: add multiprocess support to gdb_vm_state_change(), Luc Michel, 2018/11/15
- [Qemu-devel] [PATCH v6 14/16] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached, Luc Michel, 2018/11/15
- [Qemu-devel] [PATCH v6 15/16] gdbstub: add multiprocess extension support, Luc Michel, 2018/11/15
- Re: [Qemu-devel] [PATCH v6 15/16] gdbstub: add multiprocess extension support,
Edgar E. Iglesias <=
- [Qemu-devel] [PATCH v6 08/16] gdbstub: add multiprocess support to Xfer:features:read:, Luc Michel, 2018/11/15
- [Qemu-devel] [PATCH v6 13/16] gdbstub: processes initialization on new peer connection, Luc Michel, 2018/11/15
- [Qemu-devel] [PATCH v6 11/16] gdbstub: add support for extended mode packet, Luc Michel, 2018/11/15
- [Qemu-devel] [PATCH v6 07/16] gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo, Luc Michel, 2018/11/15