Re: [Qemu-devel] [PATCH] docker: dockerfile for openSUSE Leap

[Dario Faggioli]

On Sun, 2018-11-18 at 19:47 +0000, Alex Bennée wrote:
> Dario Faggioli <address@hidden> writes:
> 
> > Dockerfile for building an openSUSE Leap container.
> > 
> > Tracks the latest release (at the time of writing this
> > patch, it is Leap 15).
> > 
> > Signed-off-by: Dario Faggioli <address@hidden>
> > ---
> > Cc: "Alex Bennée" <address@hidden>
> > Cc: Fam Zheng <address@hidden>
> > Cc: "Philippe Mathieu-Daudé" <address@hidden>
> > ---
> >  tests/docker/dockerfiles/opensuse-leap.docker |   62
> > +++++++++++++++++++++++++
> >  1 file changed, 62 insertions(+)
> >  create mode 100644 tests/docker/dockerfiles/opensuse-leap.docker
> > 
> > diff --git a/tests/docker/dockerfiles/opensuse-leap.docker
> > b/tests/docker/dockerfiles/opensuse-leap.docker
> > new file mode 100644
> > index 0000000000..9d00861e66
> > --- /dev/null
> > +++ b/tests/docker/dockerfiles/opensuse-leap.docker
> > @@ -0,0 +1,62 @@
> > +FROM opensuse/leap
> > +ENV PACKAGES \
> <snip>
> > +    tar \
> > +    usbredir-devel \
> > +    virglrenderer-devel \
> > +    vte-devel \
> > +    which \
> > +    xen-devel
> > +    zlib-devel \
> 
> This hasn't been tested because the docker image fails to build due
> to
> continuation breakage.
>
It is indeed broken.

Basically, I tested it thoroughly, and I'm quite sure it works ok
(although, I'm no docker expert).

Then, when I was about to send the mail, I saw in another commit that
it was best to have the package list sorted; so I did that, and forgot
to adjust the continuation. :-(

Sorry.

I'll send a v2 with this fixed.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/

signature.asc
Description: This is a digitally signed message part