[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/10] hw/block/onenand: Fix off-by-one error allowin
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PULL 08/10] hw/block/onenand: Fix off-by-one error allowing out-of-bounds read |
Date: |
Mon, 19 Nov 2018 15:57:28 +0000 |
An off-by-one error in a switch case in onenand_read() allowed
a misbehaving guest to read off the end of a block of memory.
NB: the onenand device is used only by the "n800" and "n810"
machines, which are usable only with TCG, not KVM, so this is
not a security issue.
Reported-by: Thomas Huth <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
Message-id: address@hidden
Suggested-by: Richard Henderson <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
---
hw/block/onenand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/onenand.c b/hw/block/onenand.c
index 0cb8d7fa135..49ef68c9b14 100644
--- a/hw/block/onenand.c
+++ b/hw/block/onenand.c
@@ -608,7 +608,7 @@ static uint64_t onenand_read(void *opaque, hwaddr addr,
int offset = addr >> s->shift;
switch (offset) {
- case 0x0000 ... 0xc000:
+ case 0x0000 ... 0xbffe:
return lduw_le_p(s->boot[0] + addr);
case 0xf000: /* Manufacturer ID */
--
2.19.1
- [Qemu-devel] [PULL 00/10] target-arm queue, Peter Maydell, 2018/11/19
- [Qemu-devel] [PULL 08/10] hw/block/onenand: Fix off-by-one error allowing out-of-bounds read,
Peter Maydell <=
- [Qemu-devel] [PULL 09/10] hw/block/onenand: use qemu_log_mask() for reporting, Peter Maydell, 2018/11/19
- [Qemu-devel] [PULL 07/10] target/arm: fix smc incorrectly trapping to EL3 when secure is off, Peter Maydell, 2018/11/19
- [Qemu-devel] [PULL 04/10] target/arm: Fill in ARMISARegisters for kvm32, Peter Maydell, 2018/11/19
- [Qemu-devel] [PULL 10/10] MAINTAINERS: list myself as maintainer for various Arm boards, Peter Maydell, 2018/11/19
- [Qemu-devel] [PULL 06/10] hw/arm/stm32f205: Fix the UART and Timer region size, Peter Maydell, 2018/11/19
- [Qemu-devel] [PULL 03/10] target/arm: Introduce read_sys_reg32 for kvm32, Peter Maydell, 2018/11/19
- [Qemu-devel] [PULL 01/10] target/arm: Install ARMISARegisters from kvm host, Peter Maydell, 2018/11/19
- [Qemu-devel] [PULL 05/10] MAINTAINERS: Add entries for missing ARM boards, Peter Maydell, 2018/11/19
- [Qemu-devel] [PULL 02/10] target/arm: Fill in ARMISARegisters for kvm64, Peter Maydell, 2018/11/19
- Re: [Qemu-devel] [PULL 00/10] target-arm queue, Peter Maydell, 2018/11/19