Re: [Qemu-devel] [PATCH v2 5/9] test-string-input-visitor: Add more tests

[Eric Blake]

On 11/20/18 11:06 AM, Eric Blake wrote:
> On 11/20/18 3:25 AM, David Hildenbrand wrote:
> > Test that very big/small values are not accepted and that ranges with
> > only one element work. Also test that ranges are ascending and cannot
> > have more than 65536 elements.
> >
> > Rename expect4 to expect5, as we will be moving that to a separate ulist
> > test after the rework.
> >
> > Signed-off-by: David Hildenbrand <address@hidden>
> > ---
> >   tests/test-string-input-visitor.c | 41 +++++++++++++++++++++++++++++--
> >   1 file changed, 39 insertions(+), 2 deletions(-)
>
> Reviewed-by: Eric Blake <address@hidden>

Do we also want to test garbage strings like:

"1-" (incomplete range)
"1X-2" (garbage suffix on first element)
"1-2X" (garbage suffix on second element)

and/or

"-2--1" (valid range of signed integers)
"-1--2" (questionable whether this is valid for the two largest unsigned 
integers)

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org