[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 00/16] Don't pass flags to bdrv_reopen_queue(
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v5 00/16] Don't pass flags to bdrv_reopen_queue() |
Date: |
Tue, 20 Nov 2018 19:21:21 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Am 12.11.2018 um 15:00 hat Alberto Garcia geschrieben:
> Hi all,
>
> when reopening a BlockDriverState using bdrv_reopen() and friends the
> new options can be specified either with a QDict or with flags. Both
> methods overlap and that makes the semantics and the implementation
> unnecessarily complicated.
>
> This series removes the 'flags' parameter from these functions, so
> from now on all option changes must be specified using a QDict. Apart
> from simplifying the API, a few bugs are fixed along the way. See the
> individual patches for more details.
>
> This was tested with the current master (460f0236c12a86a38692c12d9bf).
Looks good to me, except for that one s/int/bool/ that I could do while
applying.
The only remaining question is - is all of this for 3.1, or which parts
are? It's a long series, but there are also a few bug fixes in there.
Kevin
- [Qemu-devel] [PATCH v5 15/16] block: Assert that flags are up-to-date in bdrv_reopen_prepare(), (continued)
- [Qemu-devel] [PATCH v5 15/16] block: Assert that flags are up-to-date in bdrv_reopen_prepare(), Alberto Garcia, 2018/11/12
- [Qemu-devel] [PATCH v5 09/16] block: Drop bdrv_reopen(), Alberto Garcia, 2018/11/12
- [Qemu-devel] [PATCH v5 03/16] block: Use bdrv_reopen_set_read_only() in commit_start/complete(), Alberto Garcia, 2018/11/12
- [Qemu-devel] [PATCH v5 13/16] block: Stop passing flags to bdrv_reopen_queue_child(), Alberto Garcia, 2018/11/12
- [Qemu-devel] [PATCH v5 12/16] block: Remove flags parameter from bdrv_reopen_queue(), Alberto Garcia, 2018/11/12
- [Qemu-devel] [PATCH v5 14/16] block: Remove assertions from update_flags_from_options(), Alberto Garcia, 2018/11/12
- [Qemu-devel] [PATCH v5 10/16] qemu-io: Put flag changes in the options QDict in reopen_f(), Alberto Garcia, 2018/11/12
- [Qemu-devel] [PATCH v5 04/16] block: Use bdrv_reopen_set_read_only() in bdrv_commit(), Alberto Garcia, 2018/11/12
- [Qemu-devel] [PATCH v5 07/16] block: Use bdrv_reopen_set_read_only() in external_snapshot_commit(), Alberto Garcia, 2018/11/12
- [Qemu-devel] [PATCH v5 01/16] block: Add bdrv_reopen_set_read_only(), Alberto Garcia, 2018/11/12
- Re: [Qemu-devel] [PATCH v5 00/16] Don't pass flags to bdrv_reopen_queue(),
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH v5 00/16] Don't pass flags to bdrv_reopen_queue(), Kevin Wolf, 2018/11/21