|
From: | Markus Armbruster |
Subject: | Re: [Qemu-devel] [PATCH 2/3] fw_cfg: fix -boot reboot-timeout error checking |
Date: | Tue, 20 Nov 2018 20:32:47 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Li Qiang <address@hidden> writes: > fw_cfg_reboot() gets option parameter "reboot-timeout" with > qemu_opt_get(), then converts it to an integer by hand. It neglects to > check that conversion for errors, and fails to reject negative values. > Positive values above the limit get reported and replaced by the limit. > This patch checks for conversion errors properly, and reject all valus Spelling: all values. > outside 0...0xffff. > > Signed-off-by: Li Qiang <address@hidden> Reviewed-by: Markus Armbruster <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |