[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/12] i2c: Split smbus into parts
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/12] i2c: Split smbus into parts |
Date: |
Wed, 21 Nov 2018 11:59:46 +0000 |
On 20 November 2018 at 19:30, Philippe Mathieu-Daudé <address@hidden> wrote:
> On 20/11/18 16:47, Peter Maydell wrote:
>> We don't yet use SPDX headers. (They're just a different and
>> shorter way to write the license statement.)
>
>
> Does that mean we can use them, or you rather prefer we don't?
>
> While they are machine parseable, I find them easier to understand than the
> big chunk of legal text that sometime are not correctly written.
It means that I'm not going to absolutely insist on dropping
the line if somebody submits a patch with an SPDX tag, but
I probably will mention that we don't use SPDX tags, and
definitely I'm not going to ask for them.
Overall I don't think there's much point in having them
added to one or two files randomly. If we want them then
we should consistently require them as policy. But that is
work, and so I think we should not do that until/unless
somebody (probably a corporate somebody) steps forward
to make the argument for "this is why we should have them,
we as a contributor to the project think they are worthwhile
and a useful feature for us, and we will make the effort to
add them, review that they are correct, update checkpatch to
insist on tags for new files, etc". In other words, "if it
ain't broke, don't fix it"; nobody is yet complaining that
our current setup is broken.
thanks
-- PMM
[Qemu-devel] [PATCH v2 02/12] i2c: have I2C receive operation return uint8_t, minyard, 2018/11/15
[Qemu-devel] [PATCH v2 05/12] i2c: Fix pm_smbus handling of I2C block read, minyard, 2018/11/15
[Qemu-devel] [PATCH v2 08/12] i2c: Add an SMBus vmstate structure, minyard, 2018/11/15
[Qemu-devel] [PATCH v2 07/12] i2c:pm_smbus: Fix state transfer, minyard, 2018/11/15
[Qemu-devel] [PATCH v2 06/12] boards.h: Ignore migration for SMBus devices on older machines, minyard, 2018/11/15